Import fragments in the feature to reflect p2.inf in bundles#1976
Merged
laeubi merged 1 commit intoeclipse-platform:masterfrom Jun 20, 2025
Merged
Conversation
Currently we have for the bundles that require the native fragments a p2.inf to pull them in. This does not work in the IDE as PDE has no way to understand P2 metadata that is possibly not present (e.g. when consumed from a target platform). This now adds requires/import to the feature to get the same effect when using the feature in an IDE launch without explicitly require to depend on a strict version.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have for the bundles that require the native fragments a p2.inf to pull them in. This does not work in the IDE as PDE has no way to understand P2 metadata that is possibly not present (e.g. when consumed from a target platform).
This now adds requires/import to the feature to get the same effect when using the feature in an IDE launch without explicitly require to depend on a strict version.
Thanks to eclipse-pde/eclipse.pde#1825 this now work without getting some warnings on each launch and will improve user experience when using this feature.